Skip to content

Conversation

@dr-matt-smith
Copy link
Contributor

Use lowercase-first version of entity to name repository variable in the test class

e.g. if entity named “Product” then test class repository variable will be “productRepository” rather than just “repository”

this makes copy-paste of setup code from other test classes simpler, when a related entity needs to be created for test cases

Use lower case first version of entity name to name repository variable in the test class

e.g. if entity named “Product” then repository variable will be “productRepository” rather than just “repository”

this makes copy-paste of setup code from other test classes simpler, when a related entity needs to be created for test cases
@jrushlow jrushlow added this to the v1.62.0 milestone Sep 25, 2024
@jrushlow jrushlow added Bug Bug Fix Status: Needs Review Needs to be reviewed labels Sep 25, 2024
@jrushlow jrushlow added Feature New Feature Status: Reviewed Has been reviewed by a maintainer and removed Bug Bug Fix Status: Needs Review Needs to be reviewed labels Sep 27, 2024
@jrushlow jrushlow changed the title name repository variable with entity prefix [make:crud] name repository variable with entity prefix when generating tests Sep 27, 2024
Copy link
Collaborator

@jrushlow jrushlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dr-matt-smith I appreciate the PR and the work that you do!

@jrushlow jrushlow merged commit e8d226a into symfony:main Sep 27, 2024
@dr-matt-smith
Copy link
Contributor Author

thanks for fixing the missing “-“ Jesse!
I saw the build failed but am only getting to look at it today

.. matt ..

@jrushlow jrushlow mentioned this pull request Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature New Feature Status: Reviewed Has been reviewed by a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants